fix(core): dynamically extend _slice_by_braces search_limit for massive args - #2169
Merged
Conversation
…ve args
Functions with extremely large inline parameter lists (e.g. Zig's `fn dbHelper(..., tag_to_encoding_map: *struct { ... })` where the struct spans 6,600+ characters) were silently dropped. The `_slice_by_braces` bounded search limit (`search_limit = min(next_match_start, start_idx + 2000)`) forced the search for the body's opening `{` to give up before the argument list even finished.
This dynamically extends the bound to `min(next_match_start, params_end_idx + 2000)` to safely account for large inline signatures while preserving the safety boundary against the next matching function block.
Also reconciles tri-comparison ledger sweeps for Zig and updates accuracy charts and baselines.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functions with extremely large inline parameter lists (e.g. Zig's
fn dbHelper(..., tag_to_encoding_map: *struct { ... })where the struct spans 6,600+ characters) were silently dropped. The_slice_by_bracesbounded search limit (search_limit = min(next_match_start, start_idx + 2000)) forced the search for the body's opening{to give up before the argument list even finished.This dynamically extends the bound to
min(next_match_start, params_end_idx + 2000)to safely account for large inline signatures while preserving the safety boundary against the next matching function block.Also reconciles tri-comparison ledger sweeps for Zig and updates accuracy charts and baselines.
Resolves #2166.
Resolves #2167.
Resolves #2168.